Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TODO in AppCard.tsx #16863

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: TODO in AppCard.tsx #16863

merged 1 commit into from
Sep 27, 2024

Conversation

Priyansh1547
Copy link
Contributor

Simplify AppCard.tsx by Using mutation.isPending for Loading State

This PR refactors the AppCard component by removing the redundant isLoading state and instead directly leveraging mutation.isPending to manage the loading state during the app installation process.

  • Removed the isLoadingstate.
  • Updated installation button logic to rely solely on mutation.isPending for loading indication.

This change reduces unnecessary state management and simplifies the component’s logic.

@vercel Vercel
Copy link

vercel bot commented Sep 27, 2024

@Priyansh1547 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Sep 27, 2024
@graphite-app graphite-app bot requested a review from a team September 27, 2024 16:50
@github-actions GitHub Actions
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix TODO in AppCard.tsx". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@Priyansh1547 Priyansh1547 changed the title Fix TODO in AppCard.tsx fix: TODO in AppCard.tsx Sep 27, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 27, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/27/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (09/27/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (09/27/24)

1 label was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal enabled auto-merge (squash) September 27, 2024 17:32
@anikdhabal anikdhabal merged commit 2fa7f79 into calcom:main Sep 27, 2024
52 of 79 checks passed
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anikdhabal anikdhabal anikdhabal approved these changes

Assignees
No one assigned
Labels
community Created by Linear-GitHub Sync ready-for-e2e 💻 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Priyansh1547 @CLAassistant @anikdhabal